Yes/No

Seek independent professional legal advice.
 

Check how long you are signed as a writer to the publisher and how long your copyrights are retained for.
 

Check if you have a minimum commitment, for example, how many songs you have to write per year.
 

Check what your advances and other recoupable costs are.
 

Royalties

Check on your "split" of the earnings. For example 80/20 or 75/25.
  

Check which territories you have signed for.